Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argument order of several-argument A[t|c]_mul_B[t|c]! signatures #23552

Closed
Sacha0 opened this issue Sep 1, 2017 · 3 comments
Closed

argument order of several-argument A[t|c]_mul_B[t|c]! signatures #23552

Sacha0 opened this issue Sep 1, 2017 · 3 comments
Labels
design Design of APIs or of the language itself linear algebra Linear algebra needs decision A decision on this change is needed

Comments

@Sacha0
Copy link
Member

Sacha0 commented Sep 1, 2017

Some A[t|c]_mul_B[t|c][!] signatures involving several arguments have said arguments ordered in the style of BLAS/LAPACK rather than Julia, for example

A_mul_B!::Number, A::SparseMatrixCSC, B::StridedVecOrMat, β::Number, C::StridedVecOrMat)

Such method signatures could perhaps use revision. See #20053 (comment) and #20053 (comment) for the discussion that precipitated this issue. Best!

@Sacha0 Sacha0 added needs decision A decision on this change is needed design Design of APIs or of the language itself linear algebra Linear algebra labels Sep 1, 2017
@StefanKarpinski
Copy link
Sponsor Member

Ideally, we'll be deleting these functions entirely in 1.0.

@andreasnoack
Copy link
Member

@StefanKarpinski I assume you are referring to the transposed type that would make it possible to get rid of the Ax_ and _Bx parts. However, the signature problem will remain for the new mul! function.

This is a dup of #9930.

@Sacha0
Copy link
Member Author

Sacha0 commented Sep 1, 2017

Thanks for the ref Andreas! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design of APIs or of the language itself linear algebra Linear algebra needs decision A decision on this change is needed
Projects
None yet
Development

No branches or pull requests

3 participants