Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crash in vecelement test #23796

Closed
JeffBezanson opened this issue Sep 20, 2017 · 6 comments
Closed

crash in vecelement test #23796

JeffBezanson opened this issue Sep 20, 2017 · 6 comments
Labels
bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently test This change adds or pertains to unit tests

Comments

@JeffBezanson
Copy link
Member

I've seen this many times, e.g.

https://travis-ci.org/JuliaLang/julia/jobs/277518263
https://circleci.com/gh/JuliaLang/julia/3693

Seems to be intermittent, and I have no idea whether it's actually related to VecElements, but is a definite pattern.
@JeffBezanson JeffBezanson added bug Indicates an unexpected problem or unintended behavior test This change adds or pertains to unit tests labels Sep 20, 2017
@yuyichao
Copy link
Contributor

I think this just #21918

@JeffBezanson
Copy link
Member Author

Was the fix for that issue incomplete?

@yuyichao
Copy link
Contributor

Either that or it regressed in special case. I'm not able to reproduce it but I've seen alignment of 32 specified in llvm IR. The fix is mostly a workaround to begin with.

@yuyichao
Copy link
Contributor

a workaround

-> There are a few linked PR for the more correct fix.

@vchuravy
Copy link
Member

If there are still alignments of 32 present than my fix was incomplete. I can rebase #21959 but I will probably need help to make sure that it doesn't lead to a performance regression since it is quite hot code.

This was referenced Sep 21, 2017
Merged
Merged
@amitmurthy amitmurthy mentioned this issue Sep 22, 2017
Merged
This was referenced Sep 22, 2017
Merged
Merged
This was referenced Sep 23, 2017
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@JeffBezanson JeffBezanson added the priority This should be addressed urgently label Sep 24, 2017
This was referenced Sep 24, 2017
Merged
Merged
Merged
Merged
Merged
@vtjnash vtjnash mentioned this issue Sep 26, 2017
Merged
@yuyichao yuyichao mentioned this issue Sep 26, 2017
Merged
6 tasks
@vchuravy
Copy link
Member

Should be fixed by #23883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior priority This should be addressed urgently test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vchuravy @yuyichao @JeffBezanson