replace Base.Base64 with stdlib Base64 module #24361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
excision
|
I cannot come up with this kind of solution! Thank you! |
JeffBezanson
force-pushed
the
bicycle1885-base64
branch
from
205ea95
to
c703642
Compare
|
AV passed; closed and reopened to trigger travis. |
|
Can't you just sign into Travis and restart the build? |
JeffBezanson
force-pushed
the
bicycle1885-base64
branch
from
c703642
to
1db8837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with #24285, I found a way to fully replace the current base64 code with @bicycle1885 's implementation in the stdlib, without moving anything else first.