rename JULIA_HOME => Sys.BINDIR #25102
Conversation
StefanKarpinski
force-pushed
the
sk/home
branch
from
a9074a5
to
98855af
Compare
StefanKarpinski
changed the title
contrib/mac/juliarc.jl
Outdated
| ROOT = abspath(JULIA_HOME,"..") | ||
| ENV["PATH"]="$JULIA_HOME:$(ENV["PATH"])" | ||
| ROOT = abspath(Sys.BINDIR,"..") | ||
| ENV["PATH"]="$Sys.BINDIR:$(ENV["PATH"])" |
There was a problem hiding this comment.
The interpolation here will get Sys but not BINDIR; you'll need to put parentheses around Sys.BINDIR.
StefanKarpinski
force-pushed
the
sk/home
branch
2 times, most recently
from
1927dc4
to
d031439
Compare
|
This is pretty messy. I cannot figure out how to get deprecation from Base into Sys.Base to play nicely with the these changes. So this prints lots of "precompile might be broken" warnings during CI. @vtjnash, any ideas how to do this better? I've tried every combination of eval and placement I can think of. |
|
Ok, screw the deprecations on this what – what a mess. The change itself is easy, making the deprecations not barf in all circumstances seems to be impossible, so I'm just not going to bother. |
base/deprecated.jl
Outdated
| @@ -123,11 +123,10 @@ end | |||
| deprecate(m::Module, s::Symbol, flag=1) = ccall(:jl_deprecate_binding, Void, (Any, Any, Cint), m, s, flag) | |||
|
|
|||
| macro deprecate_binding(old, new, export_old=true, dep_message=nothing) | |||
| dep_message == nothing && (dep_message = ", use $new instead") | |||
There was a problem hiding this comment.
Ah, the elusive 5 space indent...
|
Seems like you should be able to do the renaming and all of that, then just add a |
|
You would think so. But the combination of how this relates to code loading – variable definitions need to happen at a very particular point in the loading process – and the fact that the variable is not just moved inside of Base but moved into another module makes this a nightmare. There may be a way to do it, but I've already wasted enough time on this. |
StefanKarpinski
force-pushed
the
sk/home
branch
from
d031439
to
5973766
Compare
|
LGTM apart from the one 5-space indent. Nice work and thanks for going through it! |
|
Why did someone cancel the Circle CI run? |
StefanKarpinski
force-pushed
the
sk/home
branch
from
5973766
to
0acd99b
Compare
This was the only value exported from Sys with a lowercase name – all other lowercase exports are functions and values are uppercase.
ENV["JULIA_HOME"] => ENV["JULIA_BINDIR"]
StefanKarpinski
force-pushed
the
sk/home
branch
from
0acd99b
to
e83ce4b
Compare
No description provided.