-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base logging todo #25109
Comments
How much of this is user-visible? We should heavily prioritize user-visible changes since we're trying to do a feature freeze here and get an alpha out. Non-user-visible changes can continue to be made during the alpha period, although ideally those should be minimal, this seems important enough that we can allow it. |
I've organized the list here into a rough priority. I think I've got a fairly solid handle on how to do most of these things because I've already done the bulk of the investigation work and a fair chunk of the code. As to priority, I've laid them out as I see them, roughly, but happy to rearrange a bit. The main thing I feel quite unsure about at this point is the remote workers issue as I really haven't done any investigation here. |
Note that we can always keep this and add a more fine-grained mechanism on top of it in the future and just redefine the behavior of this option in terms of the more fine-grained mechanism. |
That's a good point, it's not strictly required that this be deprecated. My concern is that when implementing this with a logger, |
I guess we can always deprecate |
@c42f Does the new logging infrastructure have support for multiple simultaneous log streams? |
Yes, this is exactly the way it's designed: |
This list is kinda out of date at this point. The items which haven't been dealt with are either low priority or are tracked in their own separate issues. So I think I'll close this. |
Now that #24490 is merged containing the core functionality, there's still a lot of loose ends to tidy up, but at least they can be merged incrementally. Here's a list [edit - organized and sorted by priority]:
Important user-visible changes for 1.0
Core log message generation
jl_binding_deprecation_warning
(should fix any final parts of depwarn warnings should show location of the problem #19686 and logging() in .juliarc.jl does not work #24028)--depwarn=error
and replace with something finer grained. Arguably blocked until the previous two points are resolved.User experience / logger backends
Logging.ConsoleLogger
, with markdown-based pretty printing, and other formatting niceties which will allowSimpleLogger
to be further simplified. SeeMicroLogging.InteractiveLogger
for a start at this. See also Option to disable the location info of a logging message #25106, and RFC: Base logging #24490 (comment) at least. This is less API changes, and more setting a strong precedent for the data people include in their log events when they use the system.Non-API breaking tweaks and bug fixes
Non critical breaking changes
MakeDidn't have time to do this before 1.0.@show
use the logging system so that shown variables can be captured as values rather than text when desired. (Main issue - which log level should this be? debug kinda makes sense, but info is arguably more useful for quick hacking.)@test_logs
usage for matching multiple log messages - nicer syntax + be slightly more conservative about features.@test_logs
failureTest.Result
type - improve the way test sets capture results.Wildcards - advice needed
Pkg2
also uses separate processes extensively, and the tests clearly ended up a bit of a mess, with some logs being captured on stderr from a separate process.The text was updated successfully, but these errors were encountered: