Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Libdl to stdlib #25459

Merged
merged 1 commit into from
Jan 11, 2018
Merged

move Libdl to stdlib #25459

merged 1 commit into from
Jan 11, 2018

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added excision Removal of code from Base or the repository stdlib Julia's standard library labels Jan 8, 2018
@JeffBezanson JeffBezanson force-pushed the jb/mv_libdl branch 2 times, most recently from 1b51aea to 6f1d9de Compare January 9, 2018 06:19
@StefanKarpinski
Copy link
Member

Capitalizations of this has always bothered me. This might be a good moment to adjust it... maybe Base/Libdl => stdlib/LibDL?

@JeffBezanson JeffBezanson force-pushed the jb/mv_libdl branch 2 times, most recently from 97df002 to 16a3a6c Compare January 9, 2018 19:16
@JeffBezanson
Copy link
Member Author

Tough call; on the one hand LibDL is a bit nicer (though a bit harder to type), but Libdl is closer to the actual name of the library. It also looks a bit odd for a name to be 3/5 uppercase.

@StefanKarpinski
Copy link
Member

Your call, just thought I'd mention it while you were renaming. I slightly prefer LibDL.

@JeffBezanson JeffBezanson merged commit 9ca03c6 into master Jan 11, 2018
@JeffBezanson JeffBezanson deleted the jb/mv_libdl branch January 11, 2018 22:41
staticfloat added a commit to staticfloat/MbedTLS.jl that referenced this pull request Jan 15, 2018
JuliaLang/julia#25459 moved `Libdl` to the stdlib, which means that we need to explicitly import it now before we can do things like `Libdl.dlopen()`.
staticfloat added a commit to JuliaPackaging/BinaryBuilder.jl that referenced this pull request Jan 15, 2018
JuliaLang/julia#25459 moved `Libdl` to the
stdlib, which means that we need to explicitly import it now before we
can do things like `Libdl.dlopen()`.
staticfloat added a commit to staticfloat/MbedTLS.jl that referenced this pull request Jan 15, 2018
JuliaLang/julia#25459 moved `Libdl` to the stdlib, which means that we need to explicitly import it now before we can do things like `Libdl.dlopen()`.
staticfloat added a commit to JuliaPackaging/BinaryBuilder.jl that referenced this pull request Jan 15, 2018
JuliaLang/julia#25459 moved `Libdl` to the
stdlib, which means that we need to explicitly import it now before we
can do things like `Libdl.dlopen()`.
@thofma
Copy link
Contributor

thofma commented Jan 19, 2018

Was this intentionally without NEWS entry and deprecation warning? Tested a package on 0.7 and was greeted by ERROR: UndefVarError: Libdl not defined.

@fredrikekre fredrikekre added the needs news A NEWS entry is required for this change label Jan 19, 2018
@KristofferC KristofferC removed the needs news A NEWS entry is required for this change label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excision Removal of code from Base or the repository stdlib Julia's standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants