-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion for an improved ascii Julia logo #25587
Comments
The idea of removing the |
The ASCII art logo came first (designed by @JeffBezanson), I designed the vector logo much later to match it, so I'm not sure the ASCII logo can be inaccurate by definition 😁 |
Removing the |
Also, the left dot of the triangle should be aligned on top of the i |
|
Not sure if those circles are compliant, they seem to take up more than a unicode space (others likely more informed than me) So reverted to the previous "a", and I rounded the bottom left of the "j", and made the bottom
In my first I did also add letter spacing to match the image logo, but given what @StefanKarpinski said, perhaps I was going by the wrong ground truth! ha! |
Letter spaced version of the above, for reference
|
That's not bad! |
+1 to rounding the J. I don't like the other changes that much though. |
Whether the underscores look good in the dots is quite font-dependent. If they don't line up, it looks bad, but if they line up it looks better than without IMO. |
To be honest, if I knew that this logo was the first to be designed, before the rendered logo, I probably wouldn't have suggested edits in the first place.. Gotta respect history! |
+1 to putting the left circle directly above the |
@petertuuk As it renders on my mac, the last one I posted above has the circle directly above the i. Is that not the case for you? (I guess this is the big risk with fixing something that wasn't broken...) |
@ianshmean I now see that you posted two subsequent modifications, the second of which ("Letter spaced version of the above") does have the circle aligned. |
|
The underscores in the circles look good in a terminal with color, I think better than without. Most terminals have color (I think), thus they should be kept. |
It's not such much that circles look better when color is support AFAICT, it's just that they look better on the terminal than in GitHub, since their vertical position isn't correct there. So better not base the choice on how it looks on GitHub. |
Yeah, I think that's fair. I'll close the thread. Interesting discussion at least |
Also ref #16143 |
Obviously low priority.. But I was wondering whether the ASCII art logo when loading Julia could be a bit cleaner, and perhaps more accurate to the logo, both of which would help readability
Here's a proposed change (colorings would need to be added to the circles where appropriate)
Current version
The text was updated successfully, but these errors were encountered: