Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate module querying functions to parentmodule methods #25629

Merged
merged 3 commits into from
Jan 18, 2018
Merged

Deprecate module querying functions to parentmodule methods #25629

merged 3 commits into from
Jan 18, 2018

Conversation

ararslan
Copy link
Member

This PR adds a function parentmodule and deprecates module_parent, Base.datatype_module, and Base.function_module in favor of parentmodule methods. I find that this has a nice symmetry with the changes made in #25622.

@ararslan ararslan added the deprecation This change introduces or involves a deprecation label Jan 18, 2018
@ararslan ararslan requested a review from JeffBezanson January 18, 2018 20:20
@Sacha0
Copy link
Member

Sacha0 commented Jan 18, 2018

Ref. #25436, which was born out of discussion that e.g. enclosingmodule was a more accurate name than module_parent. Best!

@ararslan ararslan added the triage This should be discussed on a triage call label Jan 18, 2018
@JeffBezanson JeffBezanson added this to the 1.0 milestone Jan 18, 2018
@JeffBezanson JeffBezanson removed the triage This should be discussed on a triage call label Jan 18, 2018
@ararslan ararslan mentioned this pull request Jan 18, 2018
Closed
19 tasks
@JeffBezanson JeffBezanson merged commit 11cbc4d into master Jan 18, 2018
@JeffBezanson JeffBezanson deleted the aa/parentmodule branch January 18, 2018 22:55
inkydragon added a commit to inkydragon/julia that referenced this pull request Jun 19, 2022
@inkydragon
HISTORY.md: replace TODO with pr-id
b974c02 
ref: JuliaLang#25629
@inkydragon inkydragon mentioned this pull request Jun 19, 2022
Merged
aviatesk pushed a commit that referenced this pull request Jun 19, 2022
@inkydragon
HISTORY.md: replace TODO with pr-id (#45743)
c317e05 
ref: #25629
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@inkydragon @pcjentsch
HISTORY.md: replace TODO with pr-id (JuliaLang#45743)
b4aff65 
ref: JuliaLang#25629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sacha0 Sacha0 Sacha0 approved these changes

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@ararslan @Sacha0 @StefanKarpinski @JeffBezanson