contrib/build_sysimg.jl broken?

[quinnj]

docs/Docs.jl
LoadError("sysimg.jl", 567, LoadError("/Users/jacobquinn/julia/base/userimg.jl", 1, ArgumentError("Module A not found in current path.\nRun `Pkg.add(\"A\")` to install the A package.")))
ERROR: LoadError: failed process: Process(`/Users/jacobquinn/julia/usr/bin/julia -C native --output-ji nothing.ji --output-o nothing.o -J basecompiler.ji --startup-file=no sysimg.jl`, ProcessExited(1)) [1]
Stacktrace:
 [1] error(::String, ::Base.Process, ::String, ::Int64, ::String) at ./error.jl:42
 [2] pipeline_error(::Base.Process) at ./process.jl:694
 [3] run(::Cmd) at ./process.jl:656
 [4] (::getfield(, Symbol("##2#3")){Bool,String})() at /Users/jacobquinn/julia/contrib/build_sysimg.jl:81
 [5] cd(::getfield(, Symbol("##2#3")){Bool,String}, ::String) at ./file.jl:70
 [6] #build_sysimg#1(::Bool, ::Bool, ::Function, ::String, ::String, ::String) at /Users/jacobquinn/julia/contrib/build_sysimg.jl:48
 [7] (::getfield(, Symbol("#kw##build_sysimg")))(::NamedTuple{(:force, :debug),Tuple{Bool,Bool}}, ::typeof(build_sysimg), ::String, ::String, ::String) at ./<missing>:0
 [8] top-level scope at /Users/jacobquinn/julia/contrib/build_sysimg.jl:208
 [9] include at ./boot.jl:292 [inlined]
 [10] include_relative(::Module, ::String) at ./loading.jl:1011
 [11] include(::Module, ::String) at ./sysimg.jl:26
 [12] process_options(::Base.JLOptions) at ./client.jl:334
 [13] _start() at ./client.jl:386
in expression starting at /Users/jacobquinn/julia/contrib/build_sysimg.jl:208

might be same/similar problem to #25664?

[iblislin]

Because of this?

julia/base/sysimg.jl

Lines 564 to 567 in 7756d0e

	empty!(DEPOT_PATH)
	empty!(LOAD_PATH)
	Base.isfile("userimg.jl") && Base.include(Main, "userimg.jl")

LOAD_PATH got emptied.

[iblislin]

I removed these empty! and it built.

[StefanKarpinski]

That was in there before. It seems necessary to avoid double filling them in a normal build.

[iblislin]

From git blame: 4a6e64d#diff-9a4126dd8386dbc7e2eb93f7bef02d1bR460

maybe we can just switch the order of include("userimg.jl").

[StefanKarpinski]

cc @JeffBezanson, introduced along with the stdlib mechanism.

[KristofferC]

build_sysimg.jl has been deleted.