Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move Sockets out of Base #25935

Merged
merged 1 commit into from
Mar 1, 2018
Merged

move Sockets out of Base #25935

merged 1 commit into from
Mar 1, 2018

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added deprecation This change introduces or involves a deprecation excision Removal of code from Base or the repository stdlib Julia's standard library labels Feb 7, 2018
@StefanKarpinski
Copy link
Member

Nice!

@vtjnash
Copy link
Member

vtjnash commented Feb 7, 2018

Agreed, nice! I suppose you're really trying to make sure I don't upgrade libuv though (#25062)... :(

@vtjnash vtjnash closed this Feb 7, 2018
@vtjnash vtjnash reopened this Feb 7, 2018
@JeffBezanson
Copy link
Member Author

JeffBezanson commented Feb 7, 2018 •
edited
Loading

No, we can still do that. Either of these PRs shouldn't be too hard to rebase around the other.

@JeffBezanson
Copy link
Member Author

Hrm, one wrinkle here is that we allow a TCPSocket as a standard I/O stream, which makes Base depend on it. Do we need that feature?

@JeffBezanson JeffBezanson force-pushed the jb/mvsockets branch 2 times, most recently from 5ac1369 to 05af507 Compare February 8, 2018 04:09
@JeffBezanson
Copy link
Member Author

Ok, I'll just keep that for now, with the usual Ref{Module} hack, and we can decide what to do with it separately.

@JeffBezanson JeffBezanson force-pushed the jb/mvsockets branch 4 times, most recently from ee278b1 to 34c85c5 Compare February 11, 2018 18:28
@JeffBezanson
Copy link
Member Author

Interesting --- on CircleCI only, the listenany test is not able to find a port, but I haven't figured out what about these changes might cause that.

@JeffBezanson JeffBezanson force-pushed the jb/mvsockets branch 2 times, most recently from c05b624 to e344584 Compare February 14, 2018 20:29
@JeffBezanson
Copy link
Member Author

Problem solved; --skip socket needed to change to --skip Sockets in the circleci config.

@JeffBezanson JeffBezanson merged commit 180111f into master Mar 1, 2018
@JeffBezanson JeffBezanson deleted the jb/mvsockets branch March 1, 2018 20:52
@fredrikekre
Copy link
Member 

 !! No doc found for reference '[`TCPSocket`](@ref)'. [src/base/io-network.md]
 !! No doc found for reference '[`TCPSocket`](@ref)'. [src/base/io-network.md]
 !! No doc found for reference '[`TCPSocket`](@ref)'. [src/base/io-network.md]
 !! No doc found for reference '[`TCPSocket`](@ref)'. [src/base/io-network.md]
 !! No doc found for reference '[`TCPSocket`](@ref)'. [src/base/io-network.md]
 !! No doc found for reference '[`TCPSocket`](@ref)'. [src/base/io-network.md]

I think this is the same issue as #25706 (comment)

@ararslan
Copy link
Member

Was bind intentionally omitted from deprecation here?

@ararslan ararslan mentioned this pull request May 16, 2018
Merged
@JeffBezanson
Copy link
Member Author

Base.bind has a meaning for Channels.

@ararslan
Copy link
Member

Ah, okay. Thanks for clarifying.

Keno pushed a commit that referenced this pull request Jun 5, 2024
@JeffBezanson
move Sockets out of Base (#25935)
0998ebf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitmurthy amitmurthy Awaiting requested review from amitmurthy

Assignees
No one assigned
Labels
deprecation This change introduces or involves a deprecation excision Removal of code from Base or the repository stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffBezanson @StefanKarpinski @vtjnash @fredrikekre @ararslan