Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

julep: Allow passing an initial cursor to request() AbstractMenu.jl #31414

Closed
nstiurca opened this issue Mar 19, 2019 · 0 comments · Fixed by #35915
Closed

julep: Allow passing an initial cursor to request() AbstractMenu.jl #31414

nstiurca opened this issue Mar 19, 2019 · 0 comments · Fixed by #35915
Labels
REPL Julia's REPL (Read Eval Print Loop) stdlib Julia's standard library

Comments

@nstiurca
Copy link
Contributor

I find myself presenting the same menus repeatedly via REPL.TerminalMenus, and it would make sense for the default option to be whatever the user last chose.

It looks like it would be super easy to hack AbstractMenu.jl such that the cursor can optionally be initialized with something other than 1.

I should be able to hack together a PR for this over the weekend. API-wise, I'm thinking to add something like an initial_cursor::Int=1 keyword arg to the request() method that actually implements all the logic, and just forward the argument along between all the other methods. Thoughts?
@ararslan ararslan added REPL Julia's REPL (Read Eval Print Loop) stdlib Julia's standard library labels Mar 20, 2019
@timholy timholy mentioned this issue Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop) stdlib Julia's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the API of REPL.TerminalMenus JuliaLang/julia
2 participants
@nstiurca @ararslan