Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export standard log levels from Logging stdlib. #40980

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Export standard log levels from Logging stdlib. #40980

merged 1 commit into from
Jun 18, 2021

Conversation

fredrikekre
Copy link
Member

Is there a reason these are not exported?

@fredrikekre fredrikekre requested a review from c42f May 28, 2021 09:00
@fredrikekre fredrikekre added needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels May 28, 2021
@c42f
Copy link
Member

c42f commented May 28, 2021

This was a conscious choice originally because these constants have quite generic names.

At this point I'm kind of neutral on this. I do agree it's kind of annoying to have to use the Logging prefix for these and they're certainly part of the public API.

@fredrikekre
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":master")

@fredrikekre
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

c42f
c42f reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@c42f c42f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did pkgeval find any compatibility issues of note?

@fredrikekre fredrikekre force-pushed the fe/export-levels branch 2 times, most recently from 87853ed to 3541609 Compare June 17, 2021 12:28
@fredrikekre
Copy link
Member Author

No, so I updated with NEWS and tests.

@fredrikekre fredrikekre added logging The logging framework and removed needs news A NEWS entry is required for this change needs tests Unit tests are required for this change labels Jun 17, 2021
@fredrikekre fredrikekre force-pushed the fe/export-levels branch 2 times, most recently from 421fec2 to e1f7e87 Compare June 17, 2021 13:00
@fredrikekre fredrikekre merged commit dcf0f28 into master Jun 18, 2021
@fredrikekre fredrikekre deleted the fe/export-levels branch June 18, 2021 14:27
@fredrikekre fredrikekre mentioned this pull request Jun 21, 2021
Closed
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@fredrikekre @johanmon
Export standard log levels from Logging stdlib. (JuliaLang#40980)
543288b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c42f c42f c42f approved these changes

Assignees
No one assigned
Labels
logging The logging framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredrikekre @c42f @nanosoldier