Distributed: add C shell support (fixes #32690) #41485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2021
JeffBezanson
reviewed
Jul 6, 2021
JeffBezanson
reviewed
Jul 6, 2021
JeffBezanson
reviewed
Jul 6, 2021
The Unix C Shell (csh, tcsh) remains in common use as a login shell in some communities. It is not compatible with POSIX shells (bash, dash, ksh, zsh, etc.) and requires different syntax and escaping. This patch adds the function `Base.shell_escape_csh()`, a C shell equivalent of `Base.shell_escape_posixly()`, along with a new option `:csh` for the `shell` argument of `Distributed.addprocs()`, for use if the login shell on worker accounts is a C shell.
|
@JeffBezanson Thanks, I've now applied all your suggestions. |
|
Seems NEWS-worthy? |
fredrikekre
added
needs compat annotation
|
@fredrikekre Yes. I'm planning a few more SSHManager related PRs in the coming days (e.g., tidy up |
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
The Unix C Shell (csh, tcsh) remains in common use as a login shell in some communities. It is not compatible with POSIX shells (bash, dash, ksh, zsh, etc.) and requires different syntax and escaping. This patch adds the function `Base.shell_escape_csh()`, a C shell equivalent of `Base.shell_escape_posixly()`, along with a new option `:csh` for the `shell` argument of `Distributed.addprocs()`, for use if the login shell on worker accounts is a C shell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unix C Shell (csh, tcsh) remains in common use as a login shell in some communities. It is not compatible with POSIX shells (bash, dash, ksh, zsh, etc.) and requires different syntax and escaping. This patch adds the function
Base.shell_escape_csh(), a C shell equivalent ofBase.shell_escape_posixly(), along with a new option:cshfor theshellargument ofDistributed.addprocs(), for use if the login shell on worker accounts is a C shell.closes #32765
closes #37501
closes #41285