Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pkgversion(m::Module) to get the version of the package that loaded a given module #45607

Merged
merged 5 commits into from
Jun 9, 2022
Merged

Add pkgversion(m::Module) to get the version of the package that loaded a given module #45607

merged 5 commits into from
Jun 9, 2022

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jun 7, 2022 •
edited
Loading

Similar to pkgdir(m::Module) this returns the version of the package that loaded the given module or submodule.
(building on #44318)

(@v1.9) pkg> st
Status `~/.julia/environments/v1.9/Project.toml`
  [c46f51b8] ProfileView v1.5.1
  [295af30f] Revise v3.3.3

julia> using ProfileView, Revise

julia> pkgversion(ProfileView)
v"1.5.1"

julia> pkgversion(Revise)
v"3.3.3"

julia> module Foo end
Main.Foo

julia> pkgversion(Foo)

julia>

(@v1.9) pkg> st -m OrderedCollections
Status `~/.julia/environments/v1.9/Manifest.toml`
  [bac558e1] OrderedCollections v1.4.1

julia> pkgversion(Revise.OrderedCollections)
v"1.4.1"

@quinnj
Copy link
Member

quinnj commented Jun 7, 2022

Oh man, I've really wanted this! Thanks @IanButterworth!

@KristofferC
Copy link
Member

KristofferC commented Jun 8, 2022 •
edited
Loading

With #44318 we store the version when the package is loaded. So why does this PR parse the project file (again)?

@IanButterworth
Copy link
Member Author

Great question. I'll fix that.

KristofferC
KristofferC reviewed Jun 8, 2022
View reviewed changes
base/loading.jl Outdated Show resolved Hide resolved
@IanButterworth IanButterworth merged commit 7dc132c into JuliaLang:master Jun 9, 2022
@IanButterworth IanButterworth deleted the ib/pkgversion branch June 9, 2022 02:50
@IanButterworth IanButterworth mentioned this pull request Jun 9, 2022
Open
@fingolfin
Copy link
Member

fingolfin commented Jun 9, 2022 •
edited
Loading

Finally ;-) https://discourse.julialang.org/t/how-to-find-out-the-version-of-a-package-from-its-module/37755

vtjnash added a commit that referenced this pull request Jun 29, 2022
@vtjnash
loading: stop corrupting memory all over the place
6e4323e 
Regressions introduced by #45607
@vtjnash vtjnash mentioned this pull request Jun 29, 2022
Merged
vtjnash added a commit that referenced this pull request Jun 30, 2022
@vtjnash
loading: stop corrupting memory all over the place
239a1f2 
Regressions introduced by #45607
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@vtjnash
loading: stop corrupting memory all over the place
a8ad080 
Regressions introduced by #45607

(cherry picked from commit 239a1f2)
KristofferC pushed a commit that referenced this pull request Jul 4, 2022
@vtjnash
loading: stop corrupting memory all over the place
0ce21a6 
Regressions introduced by #45607

(cherry picked from commit 239a1f2)
pcjentsch pushed a commit to pcjentsch/julia that referenced this pull request Aug 18, 2022
@vtjnash @pcjentsch
loading: stop corrupting memory all over the place
46d448a 
Regressions introduced by JuliaLang#45607
@MilesCranmer MilesCranmer mentioned this pull request Oct 26, 2022
Closed
@WardBrian WardBrian mentioned this pull request Apr 3, 2023
Merged
@omus omus mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanButterworth @quinnj @KristofferC @fingolfin