Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflows in factorization #5178

Closed
simonster opened this issue Dec 16, 2013 · 1 comment · Fixed by #5526
Closed

Stack overflows in factorization #5178

simonster opened this issue Dec 16, 2013 · 1 comment · Fixed by #5526
Labels
bug Indicates an unexpected problem or unintended behavior linear algebra Linear algebra

Comments

@simonster
Copy link
Member

A lot of functions in linalg/factorization.jl (and perhaps elsewhere in LinAlg) have methods like:

function eigfact!{T<:BlasReal}(A::StridedMatrix{T}) ... end
function eigfact!{T<:BlasComplex}(A::StridedMatrix{T}) ... end
eigfact!(A::StridedMatrix) = eigfact!(float(A))

This gives a stack overflow if float(A) does not return a BlasReal or BlasComplex, e.g. if eltype(A) is Float16 or BigFloat.

@simonster
Copy link
Member Author

Related: #3014, #3864. But even if we don't have these functions, we should give a MethodError or a BlasFloat result, not a stack overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior linear algebra Linear algebra
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant