From 6087cbfa017146c26ca8f4d4e990ceadf1810969 Mon Sep 17 00:00:00 2001 From: Zentrik Date: Fri, 2 Feb 2024 15:45:37 +0000 Subject: [PATCH 1/3] Update probes.md to remove workaround Given #41616 merged I assume this workaround can be removed. I haven't tested it. --- doc/src/devdocs/probes.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/src/devdocs/probes.md b/doc/src/devdocs/probes.md index d15723e945462..cc7f7a080d18e 100644 --- a/doc/src/devdocs/probes.md +++ b/doc/src/devdocs/probes.md @@ -137,9 +137,6 @@ fib(x) = x <= 1 ? 1 : fib(x-1) + fib(x-2) beaver = @spawn begin while true fib(30) - # This safepoint is necessary until #41616, since otherwise this - # loop will never yield to GC. - GC.safepoint() end end From 49455c6d234e71e8cfa058c9ece21ccf9ce15668 Mon Sep 17 00:00:00 2001 From: Valentin Churavy Date: Sat, 10 Feb 2024 17:00:21 -0500 Subject: [PATCH 2/3] Adjust comment to drop reference to 41616 --- doc/src/devdocs/probes.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/src/devdocs/probes.md b/doc/src/devdocs/probes.md index cc7f7a080d18e..a629ce1c4bf14 100644 --- a/doc/src/devdocs/probes.md +++ b/doc/src/devdocs/probes.md @@ -137,6 +137,9 @@ fib(x) = x <= 1 ? 1 : fib(x-1) + fib(x-2) beaver = @spawn begin while true fib(30) + # A manual safepoint is necessary since otherwise this loop + # may never yield to GC. + GC.safepoint() end end From 5c306ae6e4611eeb4df2b31d925075c3b08adb37 Mon Sep 17 00:00:00 2001 From: inky Date: Sun, 11 Feb 2024 14:15:59 -0600 Subject: [PATCH 3/3] Update doc/src/devdocs/probes.md --- doc/src/devdocs/probes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/src/devdocs/probes.md b/doc/src/devdocs/probes.md index a629ce1c4bf14..e75e7f6bb0156 100644 --- a/doc/src/devdocs/probes.md +++ b/doc/src/devdocs/probes.md @@ -138,7 +138,7 @@ beaver = @spawn begin while true fib(30) # A manual safepoint is necessary since otherwise this loop - # may never yield to GC. + # may never yield to GC. GC.safepoint() end end