Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change function signature of is_ functions to be consistent with isapprox. #135

Closed
kellertuer opened this issue Nov 9, 2022 · 2 comments · Fixed by #170
Closed

Change function signature of is_ functions to be consistent with isapprox. #135

kellertuer opened this issue Nov 9, 2022 · 2 comments · Fixed by #170
Labels
breaking
Milestone
0.15.0

Comments

@kellertuer
Copy link
Member

To be consistent with the newly planned error mode, these two positional arguments of is_point (for the first) and is_vector these two should become keyword arguments.
This should also be done for the internal check_ functions also for consistency with the isapprox and check_approx functions,
see also discussions in #134.
@kellertuer kellertuer added this to the 0.14.0 milestone Nov 13, 2022
@kellertuer
Copy link
Member Author

...somehow we did not do this in 0.14.0 ;)

@mateuszbaran
Copy link
Member

I forgot to check :/.

@kellertuer kellertuer modified the milestones: 0.14.0, 0.15.0 Feb 16, 2023
@kellertuer kellertuer mentioned this issue Aug 5, 2023
Closed
20 tasks
This was referenced Oct 8, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Unify error= keyword JuliaManifolds/ManifoldsBase.jl
2 participants
@kellertuer @mateuszbaran