-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for ManifoldDiff to 0.4 for package tutorials, (keep existing compat) #426
base: master
Are you sure you want to change the base?
Conversation
…ls, (keep existing compat)
692b647
to
6d05e96
Compare
I am not really sure what is happening here. Maybe next week with a bit more sleep I try to understand the error message. |
Manopt is marked as compatible with Colors 0.13 but Manifolds.jl isn't. Dependencies for tutorials are resolved in two steps so Colors 0.13 is picked but later Pkg figures out it can't it but it's to late to downgrade. Simple solution: mark Manopt.jl as not compatible with Colors.jl until Manifolds.jl is compatible with it. |
Oh I would never have read that from the error message provided. But we do have the PR for Manifolds already, so what is missing for that? I think I'll just keep this PR open then until Manifolds.jl is compatible then. Just strange that this happens when bumping something completely different. |
We have the relevant PR here: JuliaManifolds/Manifolds.jl#763 . Maybe PythonPlot.jl tagging a new release would be enough but I haven't checked if we have any other incompatibilities in Manifolds.jl. |
In the long run we could maybe also move the plotting extension therein into a separate package, to have a bit less of these problems. |
Hi, if there is a chance (Id add +1) to have plotting in weakdeps or as an option somehow. E.g. we avoid Python dependencies as far we can, previously used Gadfly and Plots but now moving to Makie. |
Manopt.jl has plotting only as weak dependency. It would probably still be best to unify all this – including the asymptote exports I wrote long time ago into a |
This pull request changes the compat entry for the
ManifoldDiff
package from0.3.9
to0.3.9, 0.4
for package tutorials.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.