Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a release #1

Closed
ararslan opened this issue Dec 23, 2016 · 9 comments
Closed

Tag a release #1

ararslan opened this issue Dec 23, 2016 · 9 comments
Assignees
Labels

Comments

@ararslan
Copy link
Member

@stevengj Do you have any input on what should be done here before this is tagged and registered?

@ararslan ararslan self-assigned this Dec 23, 2016
@stevengj
Copy link
Member

stevengj commented Dec 23, 2016

The docs links seems to be broken. Latest docs work for me.

@ararslan
Copy link
Member Author

Stable should be a 404 until a release is tagged, since Documenter only builds stable on tag commits. Latest works for me. Does it not for you?

@stevengj
Copy link
Member

Since you're exporting gauss and kronrod, those functions need docstrings.

Also probably define

gauss(N::Integer) = gauss(Float64, N)
kronrod(N::Integer) = kronrod(Float64, N)

The README should probably link to https://github.com/ajt60gaibb/FastGaussQuadrature.jl for (non-adaptive) Gauss quadrature with more weight functions and for high orders N, since the routines here are O(N^2) whereas the ones in FastGaussQuadrature are O(N). On the other hand, the routines here support arbitrary precision, and include generation of the nested Gauss-Kronrod rules.

@stevengj
Copy link
Member

Should also grab the patches from JuliaLang/julia#19627

@stevengj
Copy link
Member

stevengj commented Dec 23, 2016

Also link https://github.com/stevengj/Cubature.jl and https://github.com/giordano/Cuba.jl for people wanting multidimensional integration (or alternative 1d algorithms, e.g. Cubature has adaptive Clenshaw-Curtis quadrature).

@ararslan
Copy link
Member Author

Should gauss and kronrod be exported? I export them here because they're exported from Base.QuadGK, but only quadgk ends up getting exported from Base.

@stevengj
Copy link
Member

I think it makes sense to export them, since they are useful functions by themselves. Too specialized to export in Base, but in a QuadGK package they make sense.

@ararslan
Copy link
Member Author

Do you know of a better way to preserve the authorship information for the change in 19627 than downloading the diff as a patch and editing it by hand?

@stevengj
Copy link
Member

Not unless @ajkeller34 wants to resubmit his PR to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants