-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge LocalArray and LocalArrayRead, rename to LocalVector #77
Comments
I like the name change. The problem with making LocalVector{T}(v::Vec; readonly=false)
return LocalVector{t, readonly}(...args...) which is type unstable, or the inner constructor: type LocalVector{T, readonly}
... fields...
function LocalVector(x::Vec)
return new(...args...)
end
end which requires specify the element type |
We could have type-stable outer constructors |
I'm not happy with the latter name either, but I can't think of anything better, so let's go with it for now. |
This was closed by #80 |
We could probably have a single type
LocalArray{T,readonly}
wherereadonly
istrue
orfalse
Also, in keeping with Julia nomenclature, it should probably be called
LocalVector
since it is a subtype ofAbstractVector
(orDenseVector
ala #76).The text was updated successfully, but these errors were encountered: