Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update precompiles #2926

Closed
ma-laforge opened this issue Aug 23, 2020 · 6 comments
Closed

[BUG] Update precompiles #2926

ma-laforge opened this issue Aug 23, 2020 · 6 comments
Labels

Comments

@ma-laforge
Copy link
Contributor

I recently sync-d my fork with Plots.jl in order to create a PR.

Now, I keep getting: [AUTO] Update precompile PRs from github-actions.

Is there a way to disable this?? I don't see info on how to stop these PRs from reaching my fork.

@ma-laforge ma-laforge added the bug label Aug 23, 2020
@daschw
Copy link
Member

daschw commented Aug 24, 2020

cc: @aminya How does the recommended workflow with SnoopCompileBot look in that case?
Also we keep getting these PRs that update the apple precompile files only (e.g. #2929). I thought you already fixed this issue.

@aminya
Copy link
Contributor

aminya commented Aug 24, 2020

You can remove the following.

on: 
 - push

or remove the SnoopCompileBot.yml workflow file altogether.

There is no other way to shut the bot down. All of the other Julia bots like TagBot, CompatHelper, etc run on the forks too.

@aminya
Copy link
Contributor

aminya commented Aug 24, 2020

Also we keep getting these PRs that update the apple precompile files only (e.g. #2929). I thought you already fixed this issue.

Could you close that PR and delete the branch? I tested this many times and it works for me!

https://github.com/aminya/Plots.jl/pull/19/files

@ma-laforge
Copy link
Contributor Author

@aminya You can remove the following.

Sorry @aminya. Was that comment to me? Are you suggesting I remove that statement or .yml file on my end?

That's perfectly acceptable to me, I just am not certain if that's what you are saying.

@ma-laforge
Copy link
Contributor Author

Alternative

If I remove the [master] branch completely, do I still get these PRs?

Because that might actually be less confusing overall.

@aminya
Copy link
Contributor

aminya commented Aug 27, 2020

@aminya You can remove the following.

Sorry @aminya. Was that comment to me? Are you suggesting I remove that statement or .yml file on my end?

That's perfectly acceptable to me, I just am not certain if that's what you are saying.

Yes. I should have tagged you. That statement specifies the triggers. Change it based on your needs. But remember if you change the code you will probably need to update the precompiles

@t-bltg t-bltg closed this as completed Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants