Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Performance regression in colobar limits #3873

Closed
BioTurboNick opened this issue Oct 10, 2021 · 1 comment · Fixed by #3874
Closed

[BUG] Performance regression in colobar limits #3873

BioTurboNick opened this issue Oct 10, 2021 · 1 comment · Fixed by #3874
Labels
bug

Comments

@BioTurboNick
Copy link
Member

Somehow my #3839 undid the benefits of my #3838. That last change to make it update at the right times did it...

🤷‍♂️

I'm looking into it.
@BioTurboNick
Copy link
Member Author

I think I got it. Two things - one is storing the computed clims values in the generic properties dictionary makes it hard for Julia to optimize. Using a typed dictionary makes that easier. The other was that it was calling the update_clims code twice every time the series was added.

@BioTurboNick BioTurboNick mentioned this issue Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for regression with colorbar limits BioTurboNick/Plots.jl
1 participant
@BioTurboNick