-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add surfaceplot
, isosurface
(support 3d plots)
#217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bltg
force-pushed
the
3d
branch
2 times, most recently
from
February 2, 2022 21:45
97fc06c
to
0db1972
Compare
t-bltg
force-pushed
the
3d
branch
2 times, most recently
from
February 2, 2022 21:52
3e6d95c
to
eeba67f
Compare
t-bltg
changed the title
Add
Add Feb 2, 2022
surfaceplot
, isosurface
(and suport 3d plots)surfaceplot
, isosurface
(support 3d plots)
t-bltg
force-pushed
the
3d
branch
2 times, most recently
from
February 2, 2022 21:59
f62834c
to
df91ece
Compare
t-bltg
force-pushed
the
3d
branch
2 times, most recently
from
February 3, 2022 07:07
a34c340
to
c543b99
Compare
johnnychen94
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the bandwidth to read all the details, but this generally looks good to me. Feel free to merge when you're ready.
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
t-bltg
force-pushed
the
3d
branch
2 times, most recently
from
February 7, 2022 10:28
55c1e73
to
51ff519
Compare
t-bltg
force-pushed
the
3d
branch
3 times, most recently
from
February 7, 2022 13:34
802fd51
to
7490a7b
Compare
t-bltg
force-pushed
the
3d
branch
4 times, most recently
from
February 7, 2022 16:28
4d66c43
to
28a4858
Compare
t-bltg
force-pushed
the
3d
branch
3 times, most recently
from
February 7, 2022 17:33
231b10f
to
72a8873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for 3d plots, along with several fixes related to 3d integration.
surfaceplot
isosurface
orthographic
andperspective
projections,azimuth
,elevation
, ...lineplot
andscatterplot
related to the complementaryPlots.jl
PR at UnicodePlots: 3d support Plots.jl#4089renamed internalshow_labels
andshow_colorbar
for consistency with keywordskwargs
->kw
: I thought I fixed all of those in a previous commit, but inconsistencies remained, fix this for goodadddefault_size!
to overrideDEFAULT_WIDTH
andDEFAULT_HEIGHT
in a consistent way (switch to dynamicwidth
andheight
inplot.jl
)Added
NaNMath
dependency for projection related issues,MarchingCubes
(registration in progress) forisosurface
, andStaticArrays
which was already a dependency triggered byContour
.