Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surfaceplot, isosurface (support 3d plots) #217

Merged
merged 51 commits into from
Feb 7, 2022
Merged

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Feb 2, 2022

This PR adds support for 3d plots, along with several fixes related to 3d integration.

  • add surfaceplot
    surfaceplot1
  • add isosurface
    isosurface
  • support orthographic and perspective projections, azimuth, elevation, ...
  • minor docstring fixes
  • some small changes in lineplot and scatterplot related to the complementary Plots.jl PR at UnicodePlots: 3d support Plots.jl#4089
  • renamed internal show_labels and show_colorbar for consistency with keywords
  • kwargs -> kw: I thought I fixed all of those in a previous commit, but inconsistencies remained, fix this for good
  • add default_size! to override DEFAULT_WIDTH and DEFAULT_HEIGHT in a consistent way (switch to dynamic width and height in plot.jl)

Added NaNMath dependency for projection related issues, MarchingCubes (registration in progress) for isosurface, and StaticArrays which was already a dependency triggered by Contour.

@t-bltg t-bltg force-pushed the 3d branch 2 times, most recently from 97fc06c to 0db1972 Compare February 2, 2022 21:45
@t-bltg t-bltg force-pushed the 3d branch 2 times, most recently from 3e6d95c to eeba67f Compare February 2, 2022 21:52
@t-bltg t-bltg changed the title Add surfaceplot, isosurface (and suport 3d plots) Add surfaceplot, isosurface (support 3d plots) Feb 2, 2022
@t-bltg t-bltg force-pushed the 3d branch 2 times, most recently from f62834c to df91ece Compare February 2, 2022 21:59
@t-bltg t-bltg force-pushed the 3d branch 2 times, most recently from a34c340 to c543b99 Compare February 3, 2022 07:07
Copy link
Collaborator

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the bandwidth to read all the details, but this generally looks good to me. Feel free to merge when you're ready.

src/volume.jl Show resolved Hide resolved
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@t-bltg t-bltg force-pushed the 3d branch 2 times, most recently from 55c1e73 to 51ff519 Compare February 7, 2022 10:28
@t-bltg t-bltg force-pushed the 3d branch 3 times, most recently from 802fd51 to 7490a7b Compare February 7, 2022 13:34
@t-bltg t-bltg force-pushed the 3d branch 4 times, most recently from 4d66c43 to 28a4858 Compare February 7, 2022 16:28
@t-bltg t-bltg force-pushed the 3d branch 3 times, most recently from 231b10f to 72a8873 Compare February 7, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants