Add MOI_PythonCall extension + Add
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 82.17% 82.20% +0.03%
==========================================
Files 19 20 +1
Lines 488 489 +1
==========================================
+ Hits 401 402 +1
Misses 87 87
☔ View full report in Codecov by Sentry. |
odow
reviewed
Oct 3, 2023
| import PythonCall | ||
|
|
||
| if !hasmethod(MOI.Utilities.map_indices, Tuple{PythonCall.Py}) | ||
| MOI.Utilities.map_indices(::Function, obj::PythonCall.Py) = obj |
There was a problem hiding this comment.
What was the motivation for adding as an extension?
MOI will always be loaded by QUBODrivers.jl (it is a direct dependency).
This method could have been added directly to src.
There was a problem hiding this comment.
MOI is always loaded but PythonCall isn't.
PythonCall is also double-trouble: besides being heavy, precompiling it involves installing and managing python deps. We don't want to add it as a QUBODrivers dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a
MOI-PythonCallextension, as discussed in jump-dev/MathOptInterface.jl#2301. Merging it closes #9.It contains the extension itself and tests.