Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compress roundtrip check is not 100% effective since it uses strings. #457

Closed
KristofferC opened this issue Aug 10, 2022 · 0 comments · Fixed by #458
Closed

The compress roundtrip check is not 100% effective since it uses strings. #457

KristofferC opened this issue Aug 10, 2022 · 0 comments · Fixed by #458

Comments

@KristofferC
Copy link
Member

In JuliaRegistries/General#65997 I effectively did a no-op by loading the Registry into the Pkg Registry datastructure and then saving it back out. However, this caused a big diff even though RegistryCI has a check for this

compressed = RegistryTools.Compress.compress(
compatfile, RegistryTools.Compress.load(compatfile)
.

The reason for this is that the Compress.load is using strings and therefore sees a difference between version specs that are written differently but are in fact the same. For example in:

gnome-shell-screenshot-1s0rlw

my PR noticed that 0.2 and 0.2.0 - 0.2 where the same version range and collapsed that into the broader version range of the package above while this was missed in CI since the strings were different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant