Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Basic 3 door, trinary multihypothesis tests" often fails numerically #1570

Open
Affie opened this issue Jul 18, 2022 · 5 comments
Open

"Basic 3 door, trinary multihypothesis tests" often fails numerically #1570

Affie opened this issue Jul 18, 2022 · 5 comments

Comments

@Affie
Copy link
Member

Affie commented Jul 18, 2022

No description provided.

@dehann
Copy link
Member

dehann commented Jul 19, 2022

This must be a regression. It was working well.

@dehann dehann modified the milestones: v0.0.x, v0.30.2 Jul 19, 2022
@dehann dehann mentioned this issue Jul 25, 2022
@Affie
Copy link
Member Author

Affie commented Jul 26, 2022

I checked v0.28 and it was failing intermittently there as well, so think we can safely eliminate the recent ArrayPartition and Manifolds v0.8 upgrade.

@dehann
Copy link
Member

dehann commented Jul 29, 2022

What I mean is the frequency of failures seem much higher to me than I remember v0.26-28 being. I looked into this a bit and could not immediately see anything wrong. Perhaps the test is just too strict, or we should change the testing strategy on this file for more amenable outcomes to current performance.

@Affie
Copy link
Member Author

Affie commented Aug 9, 2022

From #1580, it looks like this will only be done after #1010

@Affie Affie modified the milestones: v0.30.3, v0.0.x Aug 9, 2022
@dehann
Copy link
Member

dehann commented Aug 10, 2022

i still think this test used to be better. I looked at it he other day and seems like it's "working" just a bit less often than before. So there is possibly as soft bug somewhere, but let's keep moving until something more shows up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants