Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing arguments in rand! methods for StaticArrays #27

Closed
schrimpf opened this issue Oct 2, 2023 · 3 comments · Fixed by #28
Closed

missing arguments in rand! methods for StaticArrays #27

schrimpf opened this issue Oct 2, 2023 · 3 comments · Fixed by #28

Comments

@schrimpf
Copy link
Contributor

schrimpf commented Oct 2, 2023

The rand! methods for StaticArrays beginning on line 398 of api.jl don't define α, β, and γ, but use them in the call to samplevector!.
@chriselrod
Copy link
Member

That's a definite bug.
Would you be willing to make a PR fixing that and adding tests by any chance?

@schrimpf
Copy link
Contributor Author

schrimpf commented Oct 3, 2023

Sure.

@chriselrod
Copy link
Member

If you're feeling particularly ambitious, you could also turn the StaticArraysCore dependency into a weakdep/PkgExtension, so that it only gets loaded when someone is actually using StaticArrays.
https://julialang.org/blog/2023/04/julia-1.9-highlights/#package_extensions

But absolutely no pressure, any contributions welcome. I don't like letting the desire for immediate perfection be the enemy of progress.

@schrimpf schrimpf mentioned this issue Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

corrected rand! for mutable static arrays and moved them to an extension schrimpf/VectorizedRNG.jl
2 participants
@chriselrod @schrimpf