Add a basic support for parsing urls from virtual private cloud #49
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 84.32% 84.37% +0.04%
==========================================
Files 7 7
Lines 657 659 +2
==========================================
+ Hits 554 556 +2
Misses 103 103 ☔ View full report in Codecov by Sentry. |
|
|
||
| # https://bucket.vpce-1a2b3c4d-5e6f.s3.region-code.vpce.amazonaws.com/bucket-name/key-name | ||
| # https://bucket.vpce-1a2b3c4d-5e6f.s3.region-code.vpce.amazonaws.com/bucket-name | ||
| m = match(r"^https://bucket\.vpce[^\.]+\.s3\.(?<region>[^\.]+)\.vpce\.amazonaws\.com/(?<bucket>[^/]+)(?:/(?<key>.+))?$"i, url) |
There was a problem hiding this comment.
can you link to docs for the schema?
Does this have to be https://bucket.vpce-... (with literal bucket) rather than https://<bucket-name-here>.vpce-...?
There was a problem hiding this comment.
This should be a literal bucket AFAIK. I'll link the docs 👍
| @@ -531,6 +531,9 @@ end | |||
| ("S3://bucket-name", (true, false, nothing, "bucket-name", "", "")), | |||
| ("HTtp://127.0.0.1:27181/bucket-name/key-name", (true, false, "HTtp://127.0.0.1:27181", "bucket-name", "", "key-name")), | |||
| ("htTP://127.0.0.1:27181/bucket-name", (true, false, "htTP://127.0.0.1:27181", "bucket-name", "", "")), | |||
|
|
|||
| ("https://bucket.vpce-1a2b3c4d-5e6f.s3.us-west-2.vpce.amazonaws.com/bucket-name", (true, false, nothing, "bucket-name", "us-west-2", "")), | |||
| ("https://bucket.vpce-1a2b3c4d-5e6f.s3.us-west-2.vpce.amazonaws.com/bucket-name/key-name", (true, false, nothing, "bucket-name", "us-west-2", "key-name")), | |||
There was a problem hiding this comment.
are there more things we should test other than these 2 happy paths?
e.g. what if the key-name has URI encoded special characters?
Are there AWS docs on what is / isn't valid?
There was a problem hiding this comment.
Yeah, we use the same validation logic for all the URL styles, we apply it to the things we extract from the regex. I can add some cases that fail that validation.
In similar vein to JuliaServices/CloudBase.jl#35