Update dependencies #147
Open
Update dependencies #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigot
requested changes
Jul 31, 2024
Comment on lines
+18
to
+20
| HSL = "0.4" | ||
| Krylov = "0.9" | ||
| LDLFactorizations = "0.10" |
There was a problem hiding this comment.
You don't change the code, so I don't see any reason to drop these
There was a problem hiding this comment.
Because nothing is tested with older version of the packages.
There was a problem hiding this comment.
HSL 0.3 doesn't support the JLL for example.
You should not allow it!
There was a problem hiding this comment.
Still, I don't think we should drop this if no coding reason.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 82.97% 83.02% +0.05%
==========================================
Files 10 10
Lines 599 601 +2
==========================================
+ Hits 497 499 +2
Misses 102 102 ☔ View full report in Codecov by Sentry. |
|
blocked by JuliaSmoothOptimizers/CUTEst.jl#327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.