Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow C-style escapes in text input #454

Merged
merged 2 commits into from
Dec 19, 2013
Merged

Allow C-style escapes in text input #454

merged 2 commits into from
Dec 19, 2013

Conversation

johnmyleswhite
Copy link
Contributor

This closes #452 by making it possible to translate C-style escapes into their equivalents while reading in data from a DataFrame.

@simonster
Copy link
Contributor

Obviously this doesn't handle all C-style escape sequences, but that seems fine, because I don't think anyone encodes their data as bell characters. But maybe this should also handle \\? Otherwise you run the risk of misinterpreting data with a correctly escaped backslash character in it.

@johnmyleswhite
Copy link
Contributor Author

It seems reasonable to me to handle every single C-escape sequence. I just did enough to read in the file that was causing me trouble. Even the lowly bell character deserves some love.

@simonster
Copy link
Contributor

Do we care about hex, octal, and Unicode escape sequences?

@johnmyleswhite
Copy link
Contributor Author

Getting that right seemed non-trivial, which is why I bailed on it for the moment.

simonster added a commit that referenced this pull request Dec 19, 2013
Allow C-style escapes in text input
@simonster simonster merged commit a220558 into master Dec 19, 2013
@johnmyleswhite
Copy link
Contributor Author

Thanks for reviewing this, Simon!

@johnmyleswhite johnmyleswhite deleted the allowescapes branch December 19, 2013 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support equivalent of R's allowEscapes
2 participants