Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function renaming and deprecation from #517 #538

Merged
merged 1 commit into from
Feb 10, 2014
Merged

Function renaming and deprecation from #517 #538

merged 1 commit into from
Feb 10, 2014

Conversation

garborg
Copy link
Contributor

@garborg garborg commented Feb 10, 2014

This covers more of what was proposed in #517:

  • Stop exporting functions already exposed by the included using DataArrays, StatsBase
  • Stop exporting read_rda helpers
  • Remove functions that had been copied to deprecated.jl from original files
  • Move more deprecated functions to deprecated.jl
  • More of the proposed deprecations
  • More of the proposed renaming

There still isn't great symmetry in the IO function names, but nothing came to mind:

save(filename, df) loaddf(filename)
writetable(filename, df) readtable(filename)

@johnmyleswhite
Copy link
Contributor

Great job. This all looks good to me. Have we now removed all internal uses of vecbind*?

@garborg
Copy link
Contributor Author

garborg commented Feb 10, 2014

Yeah, they were already removed.

johnmyleswhite added a commit that referenced this pull request Feb 10, 2014
Function renaming and deprecation from #517
@johnmyleswhite johnmyleswhite merged commit 7f7e82c into JuliaData:master Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants