Ensure column names are valid identifiers. Closes #520 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm planning to merge this tonight. Another pair of eyes would be good -- it's not urgent, the naming scheme of the added methods doesn't seem great, but they aren't exported. |
| @@ -642,11 +641,8 @@ function parsenames!(names::Vector{Symbol}, | |||
| for j in 1:fields | |||
| left = bounds[j] + 2 | |||
| right = bounds[j + 1] | |||
| if bytes[right] == '\r' || bytes[right] == '\n' | |||
There was a problem hiding this comment.
Should this be a while loop just to be safe?
There was a problem hiding this comment.
the for j in 1:fields? or reinserting the adjustments to right and left instead of delegating that to the loops inside identifier?
|
This looks good to merge. Do whatever you'd like with my comments. |
|
Thanks for the comments! |
garborg
added a commit
that referenced
this pull request
Mar 12, 2014
Ensure column names are valid identifiers. Closes #520
nalimilan
pushed a commit
that referenced
this pull request
May 26, 2022
Ensure column names are valid identifiers. Closes #520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.