Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push!(df, row) for adding rows to a DataFrame #621

Merged
merged 3 commits into from
Jun 10, 2014
Merged

push!(df, row) for adding rows to a DataFrame #621

merged 3 commits into from
Jun 10, 2014

Conversation

catawbasam
Copy link
Contributor

No description provided.

##############################################################################


function push!(df::DataFrame, associative::Associative{Symbol,Any})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this as Base.push! rather than importing push!

@catawbasam
Copy link
Contributor Author

ok

@johnmyleswhite
Copy link
Contributor

Looks good to me. If you've got time, that one change is all I'd suggest doing.

@catawbasam
Copy link
Contributor Author

Rats. Not sure how these Travis details relate to the pull request. Any thoughts?

$ julia --code-coverage ./test/runtests.jl
ERROR: DataFrames not found
 in require at loading.jl:47
 in include at boot.jl:244
 in include_from_node1 at loading.jl:128
while loading /home/travis/build/JuliaStats/DataFrames.jl/test/runtests.jl, in expression starting on line 9

@johnmyleswhite
Copy link
Contributor

I don't see how they could be related. The tests run fine on your local machine?

@catawbasam
Copy link
Contributor Author

Yup:

[keithc@cockpit1 DataFrames]$ julia --code-coverage ./test/runtests.jl
Running tests:
    PASSED: utils.jl
    PASSED: data.jl
    PASSED: index.jl
    PASSED: dataframe.jl
    PASSED: io.jl
    PASSED: constructors.jl
    PASSED: RDA.jl
    PASSED: sort.jl
    PASSED: grouping.jl
    PASSED: join.jl
    PASSED: vcat.jl
    PASSED: iteration.jl
    PASSED: duplicates.jl
    PASSED: show.jl

@johnmyleswhite
Copy link
Contributor

Let's ignore it for now and merge away.

johnmyleswhite added a commit that referenced this pull request Jun 10, 2014
push!(df, row) for adding rows to a DataFrame
@johnmyleswhite johnmyleswhite merged commit 3cf97ff into JuliaData:master Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants