-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
push!(df, row) for adding rows to a DataFrame #621
Conversation
############################################################################## | ||
|
||
|
||
function push!(df::DataFrame, associative::Associative{Symbol,Any}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this as Base.push! rather than importing push!
ok |
Looks good to me. If you've got time, that one change is all I'd suggest doing. |
Rats. Not sure how these Travis details relate to the pull request. Any thoughts?
|
I don't see how they could be related. The tests run fine on your local machine? |
Yup:
|
Let's ignore it for now and merge away. |
push!(df, row) for adding rows to a DataFrame
No description provided.