improve formulas and revive tests #700
Conversation
|
I'll look right now. This is a very impressive PR from the look of it. |
|
LGTM. Maybe squash this before merging? |
|
@kleinschmidt, I added you as a collaborator to JuliaStats so that you'd be a collaborator on this repo. |
…nd distribute rules in formulas, and R-compatible ordering of interaction terms after sorting
kleinschmidt
force-pushed
the
dfk/formulas
branch
from
b9e49f9
to
c98d994
Compare
|
Okay, I've squashed these (although that appears to have killed @dmbates comment). Apologies for my github ignorance but I don't see how to actually merge this (or perhaps I'm not actually empowered to do that?). |
|
Did you accept the collaborator invite? If so, you should have a "merge pull request" section right above the comments box. It's yellow right now because Travis is still running. |
|
I believe @dmbates's comment lives on in GitHub's internal history as a "comment on an outdated diff". |
|
Ah, right, missed that. I'll merge this now. |
improve formulas and revive tests
improve formulas and revive tests
This implements a couple of missing features for formulas, most notably three-way and higher interactions and proper handling of associative and distributive properties of the :+ and :& operators (open to suggestions on how to improve any of these). It also restores the formula tests, removing tests for features that were previously purged and updating the remaining tests to use the up-to-date DataFrames interface.