Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allunique #302

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Use allunique #302

merged 2 commits into from
Jul 29, 2023

Conversation

devmotion
Copy link
Member

This PR contains a minor optimization: Instead of computing unique(x) and comparing its length with the length of x, it just checks allunique(x).

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (932eaac) 93.75% compared to head (37ff520) 93.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #302   +/-   ##
=======================================
  Coverage   93.75%   93.76%           
=======================================
  Files          28       28           
  Lines        1729     1731    +2     
=======================================
+ Hits         1621     1623    +2     
  Misses        108      108           
Impacted Files Coverage Δ
src/kolmogorov_smirnov.jl 96.15% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nalimilan nalimilan merged commit fba9803 into master Jul 29, 2023
@nalimilan nalimilan deleted the dw/allunique branch July 29, 2023 15:14
@nalimilan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants