Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SparseArrays a weak dependency? #174

Open
dkarrasch opened this issue Jul 27, 2023 · 3 comments · May be fixed by #188
Open

Make SparseArrays a weak dependency? #174

dkarrasch opened this issue Jul 27, 2023 · 3 comments · May be fixed by #188

Comments

@dkarrasch
Copy link
Member

From a very quick glance, it seems that a good portion of this package extends SparseArrays via PDSparseMat and related methods for it, but I wonder if, after splitting this from the main package, any dependency on SparseArrays.jl remains? If not, it would be very worthwhile to handle SparseArrays via the Pkg extension mechanism, to avoid the increased load time in Julia v1.10 due to SparseArrays.jl.
@devmotion
Copy link
Member

We would have to define PDSparseMat in the main package without restricting the type parameter to be able to export it - which is definitely possible but indicates that this implementation would not be the prototypical example of a package extension.

In general, it seems there are major issues with PDSparseMat though (#120), so maybe it should not be offered by PDMats anyway or be improved significantly.

@dkarrasch
Copy link
Member Author

Great, seems like two good reasons to make a breaking change: remove PDSparseMat and for whatever remains make SparseArrays.jl a weak dependency? 😛

@devmotion
Copy link
Member

#175 should fix these major issues with PDSparseMat, so it seems with this PR there's not a strong argument anymore for removing PDSparseMat.

@devmotion devmotion linked a pull request Oct 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify PDMat and PDSparseMat + move SparseArrays support to an extension JuliaStats/PDMats.jl
2 participants
@devmotion @dkarrasch