Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate wmedian and wquantile #443

Open
andreasnoack opened this issue Jan 9, 2019 · 2 comments
Open

Deprecate wmedian and wquantile #443

andreasnoack opened this issue Jan 9, 2019 · 2 comments

Comments

@andreasnoack
Copy link
Member

All the other weighted functions just use dispatch with an AbstractWeights vector.

@nalimilan
Copy link
Member

We discussed this API with @ararslan some time ago. IIRC the conclusion was that weights should be passed via a weights keyword argument, so that you can also pass a plain Vector. But that requires moving the method to Statistics (which we should do anyway).

I guess we could still deprecate wmedian and wquantile in the meantime.

@ararslan
Copy link
Member

ararslan commented Jan 9, 2019

I wholly support deprecating these functions. That said, it might be kind of confusing for users to migrate from wmedian to median with a weight positional argument then again to median with a keyword argument in a different package. If we're sure of the API we want in Statistics it might be a little less irritating for end users if we wait until we can make the changes there (unless of course that's way down the road).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants