Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release StatsBase.jl v1.0 #493

Open
non-Jedi opened this issue May 7, 2019 · 10 comments
Open

Release StatsBase.jl v1.0 #493

non-Jedi opened this issue May 7, 2019 · 10 comments

Comments

@non-Jedi
Copy link

non-Jedi commented May 7, 2019

Similar to JuliaStats/Distributions.jl#880. What needs to happen for StatsBase to be declared v1.0? Are there additional planned breaking changes, or missing essential functions?

@nalimilan
Copy link
Member

AFAIK the plan is rather to kill StatsBase before it reaches 1.0, by moving things to Statistics or to other more specialized packages.

@matbesancon
Copy link
Member

Given that stdlib PRs are usually slower to get in, we should start working on that

@nalimilan
Copy link
Member

That's what JuliaLang/julia#31395 starts. Hopefully other parts will require less refactoring and will just need copy/paste PRs.

@rofinn
Copy link
Member

rofinn commented Jul 3, 2019

FWIW, I don't think moving functionality to Statistics prevents us from making a 1.0 release of StatsBase. Having a major release to identify and deprecate any potentially breaking changes might actually be helpful while moving functionality into Statistics.

@juliohm
Copy link

juliohm commented Nov 14, 2019

Fully support the move to Statistics. I will be super happy the day where we can just do using Statistics in our code and have all the basic building blocks in the scope (e.g. mean, std, sample) as opposed to separating pieces in there and StatsBase. 🙏

@tpapp
Copy link
Contributor

tpapp commented Nov 15, 2019

I don't think that moving StatsBase to Statistics is a good idea before the latter is decoupled from Julia's release cycle.

StatsBase gets a release every few months, and PRs are merged without much of hassle, whereas nontrivial changes are costly to make for standard libraries. At the moment, moving to Statistics would also preclude any breaking changes, no matter how minor, until Julia 2.0.

@juliohm
Copy link

juliohm commented Nov 15, 2019

@tpapp are we still expecting major changes in the statistics API? If something is not solid yet in StatsBase.jl, it is probably because it deserves a separate package?

My main concern with the separation as it is now regards basic names like mean, std, sample being spread over different packages. Users would have a better experience by simply using Statistics and getting all these basic operations in the scope.

@tpapp
Copy link
Contributor

tpapp commented Nov 15, 2019

APIs are quite difficult to get right. It's not that existing stuff in StatsBase is less solid than in other packages — it is certainly a mature package — it's just that having the option to change things without waiting for a major release of Julia is itself valuable.

It is very hard to draw the line for what's "basic" in statistics. IMO Statistics has the "super basic" stuff that is not even statistics for most people (eg a mean), StatsBase is the best place for well-established descriptive stats, non-parametric methods, and some basic interface specs, and other packages can do more specific things.

In any case, I think this is somewhat orthogonal to this issue (conditional on StatsBase not being merged into Statistics anytime soon). Tagging a 1.0 would be useful regardless.

@nalimilan
Copy link
Member

Given that we haven't made lot of progress towards moving things to Statistics, I think we should tag 1.0 next time we want to make a breaking release. Let's mark issues with the breaking label to track these.

@brenhinkeller
Copy link

At the moment, moving to Statistics would also preclude any breaking changes, no matter how minor, until Julia 2.0.

Is adding things considered breaking? If not, that may be more of a feature than a bug :p

But I guess going 1.0 in StatsBase doesn't preclude anything on that side (if anything signals that there is no need for further API changes to the functions therein, even if they get moved to Base)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants