Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional "Invalid LngLat object: (NaN, NaN)" error on client #339

Open
toolness opened this issue Jul 27, 2020 · 5 comments
Open

Occasional "Invalid LngLat object: (NaN, NaN)" error on client #339

toolness opened this issue Jul 27, 2020 · 5 comments

Comments

@toolness
Copy link
Contributor

In the tracebacks, it looks like this is coming from Mapbox GL and/or its React wrapper, but I'm not sure what's going on, and I'm having trouble reproducing the error.

@sraby, I think I recall you mentioning this error a long time ago, do you have any insight?

@sraby
Copy link
Member

sraby commented Jul 27, 2020

@toolness does this have anything to do with #230?

@toolness
Copy link
Contributor Author

Ah possibly! The weird thing, though, is that as far as I can tell, I can't reproduce the error... If the problem was because the lat/long info isn't in PLUTO, it seems like the error would be easy to reproduce, right?

@sraby
Copy link
Member

sraby commented Jul 27, 2020

Ahhh I think I know what's going on! I think that specific error comes up when a user clicks on a "View Detail" button on the Portfolio tab for a building without lat/lng coordinates. Try this example: https://demo-whoownswhat.herokuapp.com/en/address/QUEENS/10319/68TH%20ROAD
If you go to the Portfolio tab and click on View Detail for 55 WEST 46TH STREET, you should get a Invalid LngLat object: (NaN, NaN) error logged in the console.

@sraby
Copy link
Member

sraby commented Aug 6, 2020

Ok so given our recent refactorings, it seems like this error is no longer recreatable and not being logged in RollBar anymore! You can check out both pathways to the error:

  1. https://demo-whoownswhat.justfix.nyc/en/address/BROOKLYN/2/GRACE%20COURT/portfolio — click on "View Detail" for 20 Confucious Plaza (which has no lat/lng) here goes back to the map and just deselects all the points. Great!
    2 https://demo-whoownswhat.justfix.nyc/en/address/MANHATTAN/20/CONFUCIUS%20PLAZA — here, the search address has no lat/lng but the page still shows up, just with no point on the map selected. Also great!

@sraby sraby closed this as completed Aug 6, 2020
@toolness
Copy link
Contributor Author

toolness commented Aug 7, 2020

Err, it seems to still be happening though? According to Rollbar, it's been happening for visits to some pages on the latest version of our codebase, although I can't reproduce it when I visit those URLs and click on every building in the portfolio... Still, since it appears to still be happening I'm gonna reopen this issue for now.

@toolness toolness reopened this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants