Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove update-notifier #519

Merged

Conversation

alexander-fenster
Copy link
Contributor

Hey @JustinBeckwith, how are you doing? :)

Let's drop update-notifier (at least for now), since some types got broken deep in the dependencies and I don't really want to go fix it down there.

What we see is:

node_modules/@types/cacheable-request/index.d.ts:26:42 - error TS2709: Cannot use namespace 'ResponseLike' as a type.

26         cb?: (response: ServerResponse | ResponseLike) => void
                                            ~~~~~~~~~~~~

node_modules/@types/cacheable-request/index.d.ts:77:51 - error TS2709: Cannot use namespace 'ResponseLike' as a type.

77             listener: (response: ServerResponse | ResponseLike) => void
                                                     ~~~~~~~~~~~~

I see you already dropped update-notifier from gts, so maybe just do the same here, what do you think?

Copy link

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-fenster
Copy link
Contributor Author

Relevant discussions:

DefinitelyTyped/DefinitelyTyped#62111
sindresorhus/got#2129

@JustinBeckwith JustinBeckwith merged commit 90fa80e into JustinBeckwith:main Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

🎉 This PR is included in version 4.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexander-fenster alexander-fenster deleted the no-update-notifier branch September 7, 2022 17:22
@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 8, 2022

@JustinBeckwith
Copy link
Owner

lol I had no idea that package was such a chonk. That having been said, I don't really care about package size here because it's not like this thing can ever be used from the browser 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants