-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new input to allow include statements at the top of formula class #46
Conversation
Let me get your thoughts @Justintime50 before I do any further clean up on this. |
Awesome! I'm for it. This will enable Python apps installable correct? A few thoughts:
|
Looks like Brew has Ruby packages for a few languages with some helper functions, https://rubydoc.brew.sh/Language.html. Not my area of expertise, but I would assume you could include any valid Ruby package and then reference it inside in the formula. |
Brew audit actually failed with extra whitespace. Fixing that last issue now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Small suggestion,
TLDR: the test could be even simpler to ensure we are only testing what we care about in this particular case since we have tests for those other items elsewhere.
v0.19.0 (or v1) shipped with the feature, thanks for adding that! 😃 |
Following the official guidance here for building formulas that deploy python apps. Homebrew provides built-in helper methods for different languages so I have called this generically
formula_includes
to differentiate that they are inside the Formula (open to suggestions on naming). In order to use these, they must be included inside the Formula class, but outside any of the blocks that Justintime50/homebrew-releaser currently allows for.I have added a generic placeholder that sits in the global scope of the Formula class, immediately following the metadata properties.
Example formula.rb