-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Android compile version to 33 #189
Conversation
It looks like Android 33 introduced an additional lint that is failing:
@cedrickcooke which action should we take?
|
2 is my preferred option, I believe it's
Here we're using it only as fallback behavior if we find a font-name that has not been manually associated with a resource, and once we make this fallback decision we cache the result to avoid calling it again. I feel like Krayon is doing it's part to avoid it, but I also feel like it's valuable when it comes up. |
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
============================================
+ Coverage 70.47% 79.91% +9.44%
- Complexity 67 90 +23
============================================
Files 31 25 -6
Lines 918 1240 +322
Branches 83 124 +41
============================================
+ Hits 647 991 +344
+ Misses 236 190 -46
- Partials 35 59 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly surprised only one thing broke.
No description provided.