Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Android source set layout version 2 #245

Merged
merged 2 commits into from
May 17, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented May 16, 2023

What's new in Kotlin 1.8.0: A new Android source set layout

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label May 16, 2023
@twyatt twyatt force-pushed the twyatt/androidSourceSetLayoutVersion2 branch from cc27747 to 21dd21c Compare May 16, 2023 03:24
@github-actions
Copy link

github-actions bot commented May 16, 2023

Test Results

  50 files    50 suites   31s ⏱️
252 tests 252 ✔️ 0 💤 0
297 runs  297 ✔️ 0 💤 0

Results for commit 46b5e86.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #245 (46b5e86) into main (8c86321) will increase coverage by 8.62%.
The diff coverage is 70.88%.

@@             Coverage Diff              @@
##               main     #245      +/-   ##
============================================
+ Coverage     70.47%   79.10%   +8.62%     
- Complexity       67       90      +23     
============================================
  Files            31       25       -6     
  Lines           918     1254     +336     
  Branches         83      124      +41     
============================================
+ Hits            647      992     +345     
+ Misses          236      203      -33     
- Partials         35       59      +24     
Impacted Files Coverage Δ
color/src/commonMain/kotlin/NextColor.kt 75.00% <ø> (ø)
kanvas/src/commonMain/kotlin/svg/PathString.kt 0.00% <0.00%> (-43.59%) ⬇️
shape/src/commonMain/kotlin/curve/Linear.kt 0.00% <0.00%> (ø)
kanvas/src/commonMain/kotlin/Clip.kt 41.17% <23.07%> (-18.83%) ⬇️
kanvas/src/commonMain/kotlin/Ellipse.kt 81.25% <25.00%> (-4.47%) ⬇️
kanvas/src/commonMain/kotlin/Transform.kt 72.97% <42.85%> (-11.41%) ⬇️
...vas/src/commonMain/kotlin/svg/PathStringBuilder.kt 56.00% <56.00%> (ø)
kanvas/src/commonMain/kotlin/SegmentedPath.kt 58.76% <58.76%> (ø)
color/src/commonMain/kotlin/Color.kt 89.47% <83.33%> (+1.23%) ⬆️
kanvas/src/commonMain/kotlin/Path.kt 83.33% <83.33%> (ø)
... and 10 more

... and 4 files with indirect coverage changes

@twyatt twyatt marked this pull request as ready for review May 16, 2023 03:49
@twyatt twyatt requested review from a team and cedrickcooke as code owners May 16, 2023 03:49
@twyatt twyatt requested a review from QuantumRand May 16, 2023 03:49
Copy link
Contributor

@cedrickcooke cedrickcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@twyatt twyatt enabled auto-merge (squash) May 16, 2023 07:23
@twyatt twyatt merged commit c062e70 into main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants