Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'nice' function from d3 #283

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Add 'nice' function from d3 #283

merged 2 commits into from
Oct 5, 2023

Conversation

sdonn3
Copy link
Contributor

@sdonn3 sdonn3 commented Oct 4, 2023

Previously, krayon was missing the nice function from d3 for generating intervals. This should allow us to do so

@sdonn3 sdonn3 requested review from cedrickcooke and a team as code owners October 4, 2023 22:06
@sdonn3 sdonn3 requested a review from QuantumRand October 4, 2023 22:06
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Test Results

  50 files  ±0    50 suites  ±0   9s ⏱️ -6s
252 tests ±0  252 ✔️ ±0  0 💤 ±0  0 ±0 
297 runs  ±0  297 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 017f2bf. ± Comparison against base commit 1fa01d1.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #283 (017f2bf) into main (1fa01d1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #283   +/-   ##
=========================================
  Coverage     79.10%   79.10%           
  Complexity       90       90           
=========================================
  Files            25       25           
  Lines          1254     1254           
  Branches        124      124           
=========================================
  Hits            992      992           
  Misses          203      203           
  Partials         59       59           

@twyatt twyatt added the minor Changes that should bump the MINOR version number label Oct 4, 2023
scale/src/commonMain/kotlin/Nice.kt Show resolved Hide resolved
@cedrickcooke cedrickcooke merged commit a60aef0 into main Oct 5, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Changes that should bump the MINOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants