Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default hierarchy template #297

Merged
merged 3 commits into from
Dec 2, 2023
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Nov 22, 2023

Default hierarchy template

Additional clean up:

  • dropped platform specific kotlin("test-*")s, as kotlin("test") in commonTest pulls in the necessary platform specific dependencies
  • kotlin("reflect") was not used in tests, so removed those

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Nov 22, 2023
@twyatt twyatt force-pushed the twyatt/default-hierarchy-template branch from 28dc9f7 to 4d572dc Compare November 22, 2023 08:04
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f201bb8) 79.10% compared to head (40add66) 79.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #297   +/-   ##
=========================================
  Coverage     79.10%   79.10%           
  Complexity       90       90           
=========================================
  Files            25       25           
  Lines          1254     1254           
  Branches        124      124           
=========================================
  Hits            992      992           
  Misses          203      203           
  Partials         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twyatt twyatt marked this pull request as ready for review November 22, 2023 08:17
@twyatt twyatt requested review from cedrickcooke and a team as code owners November 22, 2023 08:17
@twyatt twyatt requested a review from Phoenix7351 November 22, 2023 08:17
Copy link

github-actions bot commented Nov 22, 2023

Test Results

  50 files  ±0    50 suites  ±0   12s ⏱️ -1s
252 tests ±0  252 ✔️ ±0  0 💤 ±0  0 ±0 
297 runs  ±0  297 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 40add66. ± Comparison against base commit f201bb8.

♻️ This comment has been updated with latest results.

@twyatt twyatt enabled auto-merge (squash) November 27, 2023 23:54
@twyatt twyatt merged commit d9fab62 into main Dec 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants