Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Maven local release signing to its own workflow #343

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 1, 2024

This will allow CI to pass for PRs from forks (as demonstrated by this PR coming from my fork).

These changes make it so that release signing isn't validated until after merges to main, but I think issues with release signing should be rare.

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Apr 1, 2024
@twyatt twyatt requested review from cedrickcooke and a team as code owners April 1, 2024 20:35
@twyatt twyatt requested a review from sdonn3 April 1, 2024 20:35
@twyatt twyatt mentioned this pull request Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (14f6646) to head (d78d2fc).
Report is 22 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #343      +/-   ##
============================================
+ Coverage     79.10%   79.74%   +0.63%     
  Complexity       90       90              
============================================
  Files            25       25              
  Lines          1254     1165      -89     
  Branches        124      124              
============================================
- Hits            992      929      -63     
+ Misses          203      177      -26     
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cedrickcooke cedrickcooke enabled auto-merge (squash) April 4, 2024 20:50
@cedrickcooke cedrickcooke merged commit 554bccd into JuulLabs:main Apr 4, 2024
2 checks passed
@twyatt twyatt deleted the disable-maven-local-signing branch April 5, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants