Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kanvas source directory name for Apple targets #355

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Apr 23, 2024

I accidentally lost this commit in #353.

Renames kanvas/src/nativeDarwinMainkanvas/src/appleMain.

@twyatt twyatt added the patch Changes that should bump the PATCH version number label Apr 23, 2024
@twyatt twyatt marked this pull request as ready for review April 23, 2024 23:20
@twyatt twyatt requested review from cedrickcooke and a team as code owners April 23, 2024 23:20
@twyatt twyatt requested a review from davidtaylor-juul April 23, 2024 23:20
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.74%. Comparing base (14f6646) to head (2168c54).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #355      +/-   ##
============================================
+ Coverage     79.10%   79.74%   +0.63%     
  Complexity       90       90              
============================================
  Files            25       25              
  Lines          1254     1165      -89     
  Branches        124      124              
============================================
- Hits            992      929      -63     
+ Misses          203      177      -26     
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twyatt twyatt enabled auto-merge (squash) April 23, 2024 23:32
@twyatt twyatt merged commit 00c63e9 into JuulLabs:main Apr 23, 2024
3 checks passed
@twyatt twyatt deleted the twyatt/kanvas-apple branch April 24, 2024 00:18
@twyatt twyatt added the apple label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants