Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Recently-compatible installed mods missing from compatible filter #2883

Closed
skalou opened this issue Oct 7, 2019 · 9 comments · Fixed by #2886
Closed

[Bug] Recently-compatible installed mods missing from compatible filter #2883

skalou opened this issue Oct 7, 2019 · 9 comments · Fixed by #2886
Assignees
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI

Comments

@skalou
Copy link

skalou commented Oct 7, 2019

Background

  • Operating System: windows 10
  • CKAN Version: v1.26.4
  • KSP Version: v1.7.3.2594

Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
No

Problem

Describe the bug

Hello, I'm the owner of 2 mods:

I installed them a long time ago, and now I can't see them with compatibility filter unless i set it to allow KSP version 1.3, but my MOD.version file on my github page describe it as compatible with KSP 1.7.3 and CKAN see it well (in the Max KSP version collumn)
However the MOD.version file in the GameData/MOD is set to old KSP version, but i update the MOD.version file on my github pages for KSP-AVC.

Uninstalling and reinstalling fixes the problem.

Steps to reproduce

  1. Open CKAN with KSP 1.3.1 installed when AblativeAirbrake and Mk1CabinHatch were only compatible with KSP 1.3.1 (approx. March 2018 and earlier)
  2. Install AblativeAirbrake and Mk1CabinHatch
  3. Upgrade KSP to 1.7.3
  4. Wait for AblativeAirbrake and Mk1CabinHatch to add support up to KSP 1.7 (approx. May 2019 and later)
  5. Settings > Compatible KSP version > tick only 1.7
  6. set filter to "compatible",
  7. search for my mods "Mk1-Cabin-Hatch" or "Ablative-Airbrake", they are not visible
  8. Settings > Compatible KSP version > tick 1.3
  9. my mods are now visible

CKAN folder generated by the above steps for testing:

@HebaruSan

This comment has been minimized.

@HebaruSan

This comment has been minimized.

@skalou
Copy link
Author

skalou commented Oct 7, 2019

The registry update when launching CKAN? ( i restarted it maybe 20x, with windows restart too, during maybe 2 month.
Or how to refresh the registry please ? Or totally remove CKAN and reinstall it?
i tried to delete the download cache in Settings > CKAN settings > Purge > purge All
but i still don't see my mod with the filter (compatible)

image

thank you HebaruSan

@HebaruSan

This comment has been minimized.

@skalou
Copy link
Author

skalou commented Oct 7, 2019

I tried the refresh button too, it don't change.

But if i delete the CKAN folder inside my "Kerbal Space Program" folder install, it works as it should (after launching Ckan.exe it create a new one).
So it's OK for me.

i saved the old CKAN folder ( with GUIConfig.xml files etc... inside), do you want it to check for a bug ?
here it is: CKAN.zip

thank you for your help ( it's better a bug just for myself than for all of the users)

@HebaruSan HebaruSan changed the title [Bug] [Bug] Compatible mods missing from compatible filter Oct 8, 2019
@HebaruSan
Copy link
Member

OK, I'm able to reproduce the problem using your files, but a crucial piece of information was missing:
Both mods are already installed! That should be in the steps to reproduce; I'll add it now.

@HebaruSan HebaruSan changed the title [Bug] Compatible mods missing from compatible filter [Bug] Compatible installed mods missing from compatible filter Oct 9, 2019
@HebaruSan
Copy link
Member

... aaand that makes sense. The InstalledModule still has the old compatibility info from when it was installed. So either we need to update the installed module, or the filter needs to look at the available module instead.

"AblativeAirbrake": {
	"install_time": "2018-03-19T19:49:28.4893785+01:00",
	"source_module": {
		"abstract": "A derived stockalike airbrake coated with ablator. ",
		"author": [
			"Skalou2"
		],
		"depends": [
			{
				"name": "ModuleManager"
			}
		],
		"download": "https://spacedock.info/mod/1245/Ablative-Airbrake/download/0.3.0",
		"download_size": 39032,
		"download_hash": {
			"sha1": "FA445D3E2FBB8BFE7F2C18C44759C1CFB500DC82",
			"sha256": "CFFE8DDEB606BE2C0C68C9E08B6714A33A4599B0EDDEF40CE8BFE78E23290F27"
		},
		"identifier": "AblativeAirbrake",
		"ksp_version": "1.3.1",
		"license": [
			"GPL-3.0"
		],
		"name": "Ablative-Airbrake",
		"resources": {
			"homepage": "http://forum.kerbalspaceprogram.com/index.php?/topic/157353-122-ablative-airbrake-v010-5-march-2017/",
			"spacedock": "https://spacedock.info/mod/1245/Ablative-Airbrake"
		},
		"version": "0.3.0",
		"install": [
			{
				"find": "Ablative-Airbrake"
			}
		],
		"spec_version": "v1.4"
	},

@HebaruSan HebaruSan added Bug Something is not working as intended GUI Issues affecting the interactive GUI labels Oct 9, 2019
@HebaruSan HebaruSan changed the title [Bug] Compatible installed mods missing from compatible filter [Bug] Recently-compatible installed mods missing from compatible filter Oct 9, 2019
@skalou
Copy link
Author

skalou commented Oct 10, 2019

i'm happy to contribute for this great add-on, thank you for your help anyway.
tell me if u need something more from me, test etc...

@HebaruSan
Copy link
Member

Thanks @skalou ! Saving your CKAN folder for inspection was a master stroke, I think we have this one figured out now thanks to that.

@HebaruSan HebaruSan self-assigned this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants