Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Download cache change management #4086

Closed
gsf600y opened this issue May 14, 2024 · 1 comment · Fixed by #4240
Closed

[Feature]: Download cache change management #4086

gsf600y opened this issue May 14, 2024 · 1 comment · Fixed by #4240
Assignees
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI

Comments

@gsf600y
Copy link

gsf600y commented May 14, 2024

Problem

When updating the cache folder to a new location, existing contents of the cache are not moved to the new location, and the existing contents are not deleted.
This means that the existing contents effectively become orphaned files.
CKAN still appears to have them marked as being downloaded, and allows the "purge from cache" option to be selected, however when clicking on this option it does not delete the cached download from what is now the old location.

Suggestion

When changing the download cache location, the existing cache data should be moved to the new cache location, potentially unless an option is ticked not to override one of these defaults.

Alternatives

Alternatively, the old cache should be purged automatically when selecting a new location.

Another alternative would be to take no actions with the old cache, but prompt the user that the old location still contains data, e.g.
"Old cache location contains xxx MiB of data. Do you wish to purge?"

Additional context

No response

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Core (ckan.dll) Issues affecting the core part of CKAN labels May 14, 2024
@HebaruSan
Copy link
Member

HebaruSan commented Oct 21, 2024

Previous related changes for reference:

In addition to all of the above, there should probably be a progress bar in case moving several GiB of files from one spot to another is sometimes not a quick process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants