Configure FileInitDataParser to omit spaces around '=' when writing config files (#1498)

[danielrschmidt]

Changed the AssigmentSpacer of the FileIniDataParser instance to the empty string. This removes spaces around the '=' in the kde mimeapps and .desktop files and should enable KDE to parse the files without issues. Fixes #1498 on my system.

[pjf]

This looks good to me, although I had to double check that 'AssigmentSpacer' was the actual name of the field. Testing now and will merge if all looks good. :)

[pjf]

Working for me! Thank you! Merging now with great thanks!

[politas]

Where does FileInitDataParser come from?

[pjf]

@politas : It's a third-party library we link against. I believe (but not checked) it's this one.

[politas]

Hoo boy! I do not understand C#.

[pjf]

@politas:

The relevant lines are way up the top of the file:

using IniParser;
using IniParser.Exceptions;
using IniParser.Model;

When I first started working on the CKAN over a year ago I had no idea where anything came from. There was lots of comments saying 'Help! How do I do X in C#?'. :)

[politas]

I've never fully absorbed the idea of inheritance. I can work with pretty much any procedural language, but this object stuff makes my head melt. If you need some help getting something complex done within a procedure, let me know and I'll knock out some torturous pseudocode to get it done, but every time I try to look at this code, I just don't know where to start to understand it.

[danielrschmidt]

Glad to be of help, CKAN is really awesome! As for the AssigmentSeparator field... that threw me off at first, too, thought it was some weird C# issue before I realized that there was no 'n' in Assigment ;) Considered filing an issue with IniParser, but then again that would just raise a bunch of compatibility issues for CKAN.

[politas]

Typos in API and public titles are a nuisance. At work, I regularly have to look at a text string that says "The 5 varibles are...", which annoys the heck out of me.

[politas]

Have both mimeapps.list and CKAN Launcher.desktop file creation been tested with spaces in file paths, to make sure they are properly escaped? Do we have a list of unit tests for these portions somewhere?